'\'Fish\' (David B. Trout)' david.b.trout@gmail.com [hercules-390]
2017-12-08 04:33:35 UTC
Question mostly for the developers but others are free to reply with their opinion/thoughts as well.
I've been working on overhauling Hercules's facilities support(*) and I noticed something that doesn't seem right to me.
In source file feat390.h there are more than a few z/Architecture facilities being enabled that, *technically* (if I'm reading the SA22-7201-08 (June 2003) ESA/390 Principles of Operation manual correctly), should not be enabled.
Page 10-91 describes the behavior of the STFL (Store Facility List) instruction and only documents facility bits 0-5 and 16-20. It further states:
"Bits 6-15 and 21-31 are reserved for indication
of new facilities. The bits are currently stored
as zeros but may be stored as ones in the future."
Yet, in header feat390.h, I'm seeing the following facilities being enabled:
FEATURE_ETF2_ENHANCEMENT_FACILITY
FEATURE_ETF3_ENHANCEMENT_FACILITY
FEATURE_EXTENDED_TRANSLATION_FACILITY_3
FEATURE_FPS_ENHANCEMENT
FEATURE_FPS_EXTENSIONS
INTERLOCKED_ACCESS_FACILITY_2
FEATURE_MESSAGE_SECURITY_ASSIST_EXTENSION_3
FEATURE_MESSAGE_SECURITY_ASSIST_EXTENSION_4
FEATURE_STORE_FACILITY_LIST_EXTENDED_FACILITY
which correspond to facility list bits 24, 30, 22, 41, 37, 52, 76, 77 and 7, respectively.
The enabling of the FEATURE_STORE_FACILITY_LIST_EXTENDED_FACILITY facility (bit 7) is especially puzzling (highly questionable IMHO) since the ESA/390 Principles of Operation doesn't even list the STFLE instruction as being a valid instruction for the architecture (and as demonstrated doesn't consider facility list bit 7 to be valid).
Can someone please explain to me why these facilities are being enabled for ESA/390 when there's every indication that, according to available documentation, they *shouldn't* be?
Is there something I'm missing or not understanding correctly about Hercules that for some reason requires them to be enabled? Would something I'm unaware of break horribly if I removed (commented out) those statements?
Thanks!
I've been working on overhauling Hercules's facilities support(*) and I noticed something that doesn't seem right to me.
In source file feat390.h there are more than a few z/Architecture facilities being enabled that, *technically* (if I'm reading the SA22-7201-08 (June 2003) ESA/390 Principles of Operation manual correctly), should not be enabled.
Page 10-91 describes the behavior of the STFL (Store Facility List) instruction and only documents facility bits 0-5 and 16-20. It further states:
"Bits 6-15 and 21-31 are reserved for indication
of new facilities. The bits are currently stored
as zeros but may be stored as ones in the future."
Yet, in header feat390.h, I'm seeing the following facilities being enabled:
FEATURE_ETF2_ENHANCEMENT_FACILITY
FEATURE_ETF3_ENHANCEMENT_FACILITY
FEATURE_EXTENDED_TRANSLATION_FACILITY_3
FEATURE_FPS_ENHANCEMENT
FEATURE_FPS_EXTENSIONS
INTERLOCKED_ACCESS_FACILITY_2
FEATURE_MESSAGE_SECURITY_ASSIST_EXTENSION_3
FEATURE_MESSAGE_SECURITY_ASSIST_EXTENSION_4
FEATURE_STORE_FACILITY_LIST_EXTENDED_FACILITY
which correspond to facility list bits 24, 30, 22, 41, 37, 52, 76, 77 and 7, respectively.
The enabling of the FEATURE_STORE_FACILITY_LIST_EXTENDED_FACILITY facility (bit 7) is especially puzzling (highly questionable IMHO) since the ESA/390 Principles of Operation doesn't even list the STFLE instruction as being a valid instruction for the architecture (and as demonstrated doesn't consider facility list bit 7 to be valid).
Can someone please explain to me why these facilities are being enabled for ESA/390 when there's every indication that, according to available documentation, they *shouldn't* be?
Is there something I'm missing or not understanding correctly about Hercules that for some reason requires them to be enabled? Would something I'm unaware of break horribly if I removed (commented out) those statements?
Thanks!
--
"Fish" (David B. Trout)
Software Development Laboratories
http://www.softdevlabs.com
mail: ***@softdevlabs.com
(*) Issue #71 "Facilities support needs auditing / improved" of my repository (https://github.com/Fish-Git/hyperion/issues/71)
"Fish" (David B. Trout)
Software Development Laboratories
http://www.softdevlabs.com
mail: ***@softdevlabs.com
(*) Issue #71 "Facilities support needs auditing / improved" of my repository (https://github.com/Fish-Git/hyperion/issues/71)